WIP: Return more KCL outcome data when executing - #1348
Open
adamchalmers wants to merge 2 commits into
Open
Conversation
adamchalmers
changed the title
jtran
approved these changes
Aug 27, 2026
| [patch.crates-io] | ||
| kittycad-unit-conversion-derive = { path = "unit-conversion-derive" } | ||
| kcl-api = { path = "/Users/adamchalmers/kc-repos/modeling-app/rust/kcl-api" } | ||
| kcl-error = { path = "/Users/adamchalmers/kc-repos/modeling-app/rust/kcl-error" } |
adamchalmers
force-pushed
the
achalmers/augment-kcl-exec
branch
from
August 27, 2026 23:57
e05cb6e to
c081596
Compare
adamchalmers
added a commit
to KittyCAD/modeling-app
that referenced
this pull request
Aug 28, 2026
These will be used to pull CadOperation into the modeling-cmds API, so it can be returned during engine execution. Part of #12500 Used in KittyCAD/modeling-api#1348
adamchalmers
force-pushed
the
achalmers/augment-kcl-exec
branch
from
August 28, 2026 02:28
c081596 to
ee9192e
Compare
adamchalmers
force-pushed
the
achalmers/augment-kcl-exec
branch
from
August 28, 2026 02:36
ee9192e to
51c7d42
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1348 +/- ##
=======================================
Coverage ? 31.56%
=======================================
Files ? 31
Lines ? 1644
Branches ? 0
=======================================
Hits ? 519
Misses ? 1125
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
adamchalmers
force-pushed
the
achalmers/augment-kcl-exec
branch
from
August 28, 2026 14:01
b9236fb to
387c76f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires KittyCAD/modeling-app#13362, CI will not pass until that is released.
Part of engine execution effort: KittyCAD/modeling-app#12500