Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1150 +/- ##
=======================================
Coverage ? 30.35%
=======================================
Files ? 34
Lines ? 1591
Branches ? 0
=======================================
Hits ? 483
Misses ? 1108
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
iterion
approved these changes
Apr 2, 2026
jtran
reviewed
Apr 2, 2026
| pub highlight_color: Option<Color>, | ||
| /// The default color to use for selection | ||
| #[serde(default)] | ||
| pub selection_color: Option<Color>, |
Contributor
There was a problem hiding this comment.
Are these fields required? I think we probably should also use #[builder(default)] so that it's not a breaking change.
Collaborator
There was a problem hiding this comment.
They're not required!
Contributor
Author
There was a problem hiding this comment.
Interesting, I'm getting this error when just adding #[builder(default)]
error: `Option<_>` already implies a default of `None`, so explicit #[builder(default)] is redundant
--> modeling-cmds/src/def_enum.rs:1601:23
|
1601 | #[builder(default)]
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1149. Follow-up to https://github.com/KittyCAD/engine/pull/4280, needed for KittyCAD/modeling-app#10740