Open
Conversation
This is purely a refactor, I don't expect any behavioural changes. Purpose of the refactor is: Bon (our builder API macro crate) doesn't work on enums. But some enums have struct-like named fields, making them very close to a struct and therefore having all the same problems, e.g. when you add a field, it'll cause compile errors in the engine, forcing people to handle those new fields. Solution is to move those enum fields into a new struct, which CAN have the Builder derive on it. This is going to make the new Face API easier to integrate by causing fewer compile errors. Also incidentally bump rustls
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1145 +/- ##
=======================================
Coverage ? 30.22%
=======================================
Files ? 34
Lines ? 1588
Branches ? 0
=======================================
Hits ? 480
Misses ? 1108
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
iterion
approved these changes
Mar 30, 2026
Contributor
iterion
left a comment
There was a problem hiding this comment.
iiuc this is a breaking change for the Rust types but not for the API itself, and the api.json suggests the same
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is purely a refactor, I don't expect any behavioural changes.
Purpose of the refactor is: Bon (our builder API macro crate) doesn't work on enums. But some enums have struct-like named fields, making them very close to a struct and therefore having all the same problems, e.g. when you add a field, it'll cause compile errors in the engine, forcing people to handle those new fields.
Solution is to move those enum fields into a new struct, which CAN have the Builder derive on it.
This is going to make the new Face API easier to integrate by causing fewer compile errors. Moving these fields into named structs will be a breaking change, but it's a very easy breaking change, and will reduce future changes.
Also incidentally bump rustls for a security patch.