Repository navigation
Fix updater downloads on GNU Linux and run the test in CI - #1957
Merged
Merged
Conversation
paultag
approved these changes
Nov 5, 2026
jessfraz
marked this pull request as ready for review
November 5, 2026 21:19
jessfraz
enabled auto-merge (squash)
November 5, 2026 21:23
Contributor
|
I ran the tests locally and it passed with your new method but there appears to be an issue with integration tests not the CLI repo itself. |
Contributor
Author
|
i fixed those they were just stale |
Contributor
Author
|
kcl versioning bullshit |
This reverts commit e6733d4.
Contributor
|
Okay, push the updates when you get the chance. |
Contributor
|
thanks for pushing, I tested and local passes for me. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1957 +/- ##
==========================================
+ Coverage 68.21% 68.68% +0.47%
==========================================
Files 43 43
Lines 8745 8748 +3
==========================================
+ Hits 5965 6009 +44
+ Misses 2780 2739 -41
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the published musl binaries for GNU Linux builds and run the real updater
download/checksum test in CI. Missing assets now report HTTP errors.
Use the small cylinder fixture for the mass, table analysis, and project
snapshot smoke tests. Check mass numerically with a 0.2% tolerance and save the
snapshot to a temporary file. Give external KCL tests two retries and a
five-minute timeout per attempt in CI.
Fixes #1956