Skip to content

Fix updater downloads on GNU Linux and run the test in CI - #1957

Merged
jessfraz merged 8 commits into
mainfrom
codex/fix-updater-linux
Nov 5, 2026
Merged

jessfraz merged 8 commits into
mainfrom
codex/fix-updater-linux

Conversation

@jessfraz

@jessfraz jessfraz commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Use the published musl binaries for GNU Linux builds and run the real updater
download/checksum test in CI. Missing assets now report HTTP errors.

Use the small cylinder fixture for the mass, table analysis, and project
snapshot smoke tests. Check mass numerically with a 0.2% tolerance and save the
snapshot to a temporary file. Give external KCL tests two retries and a
five-minute timeout per attempt in CI.

Fixes #1956

@jessfraz
jessfraz marked this pull request as ready for review November 5, 2026 21:19
@jessfraz
jessfraz enabled auto-merge (squash) November 5, 2026 21:23
@nadr0

nadr0 commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

I ran the tests locally and it passed with your new method but there appears to be an issue with integration tests not the CLI repo itself.

     Summary [  14.091s] 178 tests run: 174 passed, 4 failed, 1 skipped
        FAIL [  12.395s] zoo::bin/zoo tests::analyze_a_kcl_file_with_non_fatal_errors_allowed_exits_zero
        FAIL [  11.930s] zoo::bin/zoo tests::analyze_a_kcl_file_with_non_fatal_errors_exits_non_zero
        FAIL [  12.395s] zoo::bin/zoo tests::export_a_kcl_file_with_non_fatal_errors_allowed_exits_zero
        FAIL [  12.210s] zoo::bin/zoo tests::export_a_kcl_file_with_non_fatal_errors_exits_non_zero

@jessfraz

jessfraz commented Nov 5, 2026

Copy link
Copy Markdown
Contributor Author

i fixed those they were just stale

@jessfraz

jessfraz commented Nov 5, 2026

Copy link
Copy Markdown
Contributor Author

kcl versioning bullshit

@nadr0

nadr0 commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

Okay, push the updates when you get the chance.

@nadr0

nadr0 commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

thanks for pushing, I tested and local passes for me.

@jessfraz
jessfraz merged commit 05c6552 into main Nov 5, 2026
31 of 34 checks passed
@jessfraz
jessfraz deleted the codex/fix-updater-linux branch November 5, 2026 23:58
@codecov

codecov Bot commented Nov 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.68%. Comparing base (0077fb3) to head (9d3981f).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1957      +/-   ##
==========================================
+ Coverage   68.21%   68.68%   +0.47%     
==========================================
  Files          43       43              
  Lines        8745     8748       +3     
==========================================
+ Hits         5965     6009      +44     
+ Misses       2780     2739      -41     
Flag Coverage Δ
unittests 68.68% <100.00%> (+0.47%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: test_download_binary_to_temp_file

3 participants