Execute KCL on engine by default - #1793
Merged
Merged
Conversation
jessfraz
approved these changes
Aug 12, 2026
adamchalmers
force-pushed
the
achalmers/default-eng-exec
branch
from
August 13, 2026 00:41
6db040d to
a5172b2
Compare
Opt out by passing ENGINE_EXECUTION=0
adamchalmers
force-pushed
the
achalmers/default-eng-exec
branch
from
August 29, 2026 03:08
a5172b2 to
4d266cd
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1793 +/- ##
==========================================
- Coverage 67.05% 65.94% -1.12%
==========================================
Files 43 43
Lines 8421 8434 +13
==========================================
- Hits 5647 5562 -85
- Misses 2774 2872 +98
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
adamchalmers
commented
Aug 29, 2026
| for issue in issues { | ||
| writeln!(err_out, "{:?}: {}", issue.severity, issue.message)?; | ||
| for (i, issue) in issues.iter().enumerate() { | ||
| if i > 0 { |
Contributor
Author
There was a problem hiding this comment.
Put newlines between error blocks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opt out by passing ENGINE_EXECUTION=0