Skip to content

test: Add retries to tests for engine flakiness#1713

Open
jtran wants to merge 10 commits into
mainfrom
jtran/test-retries
Open

test: Add retries to tests for engine flakiness#1713
jtran wants to merge 10 commits into
mainfrom
jtran/test-retries

Conversation

@jtran

@jtran jtran commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Test flakiness seems to have increased since #1527, and we need to re-run CI jobs more frequently now.

This PR adds retrying in tests. It only retries when errors implement the IsRetryable trait, and that returns true.

When a retryable error occurs, the entire engine connection needs to be scrapped, and everything needs to be redone.

@codecov

codecov Bot commented Jul 8, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 93.37748% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.35%. Comparing base (d038ace) to head (e58a31c).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/context.rs 93.15% 20 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1713      +/-   ##
==========================================
+ Coverage   66.28%   67.35%   +1.07%     
==========================================
  Files          44       45       +1     
  Lines        8476     9065     +589     
==========================================
+ Hits         5618     6106     +488     
- Misses       2858     2959     +101     
Flag Coverage Δ
unittests 67.35% <93.37%> (+1.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jtran jtran force-pushed the jtran/test-retries branch from 7b42331 to e58a31c Compare July 8, 2026 01:49
@jtran jtran marked this pull request as ready for review July 8, 2026 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants