Support engine execution for KCL commands#1711
Open
adamchalmers wants to merge 2 commits into
Open
Conversation
adamchalmers
force-pushed
the
achalmers/export-remote
branch
from
aacdcd2 to
938b7cc
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1711 +/- ##
==========================================
- Coverage 65.21% 64.02% -1.19%
==========================================
Files 44 45 +1
Lines 8219 8587 +368
==========================================
+ Hits 5360 5498 +138
- Misses 2859 3089 +230
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
adamchalmers
commented
Jul 7, 2026
| let units: UnitLength = meta_settings.default_length_units.to_kcmc(); | ||
| let output_format = get_output_format(&self.output_format, units, self.deterministic); | ||
|
|
||
| if crate::context::Context::use_server_kcl_execution() { |
Contributor
Author
There was a problem hiding this comment.
Export is a weird case. All the other commands use a nice general utility function, "execute this KCL then run these commands as a follow-up", but not export. So it has its own explicit logic for engine execution here. Will fix this up in a followup PR.
adamchalmers
changed the title
jtran
approved these changes
Jul 7, 2026
adamchalmers
force-pushed
the
achalmers/export-remote
branch
2 times, most recently
from
5de827e to
b12f305
Compare
This is around 20x faster on large models. Set ENGINE_EXECUTION to any nonempty string to activate. Off by default.
adamchalmers
force-pushed
the
achalmers/export-remote
branch
from
b12f305 to
688efbe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting
$ENGINE_EXECUTIONto any non-empty string will execute KCL on the engine instead of locally.This produces a significant speedup: