Skip to content

Fix: Uninstall: OAuth Client ID#156

Merged
n7studios merged 1 commit into
js-coding-standards-pin-typescript-versionfrom
fix-uninstall-client-id
Jul 14, 2026
Merged

Fix: Uninstall: OAuth Client ID#156
n7studios merged 1 commit into
js-coding-standards-pin-typescript-versionfrom
fix-uninstall-client-id

Conversation

@n7studios

Copy link
Copy Markdown
Contributor

Summary

uninstall.php incorrectly has the WooCommerce OAuth Client ID.

This PR resolves by using the WPForms OAuth Client ID. We can't use Plugin classes, methods or constants to instead use the INTEGRATE_CONVERTKIT_WPFORMS_OAUTH_CLIENT_ID constant, as they're not always reliably available during a Plugin's uninstallation.

Testing

Existing tests pass.

Checklist

@n7studios n7studios self-assigned this Jul 13, 2026
@n7studios n7studios added the bug Something isn't working label Jul 13, 2026
@n7studios n7studios requested review from a team, ciccio-kit and noelherrick and removed request for a team July 13, 2026 03:44
@n7studios n7studios marked this pull request as ready for review July 13, 2026 03:44
@n7studios n7studios merged commit 2b8d506 into js-coding-standards-pin-typescript-version Jul 14, 2026
50 of 51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants