Repository navigation
Add tpcc sync switch and reuse LMDB point-lookup cursor - #391
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (63.49%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #391 +/- ##
==========================================
- Coverage 93.68% 93.64% -0.05%
==========================================
Files 260 260
Lines 48783 48844 +61
==========================================
+ Hits 45704 45741 +37
- Misses 3079 3103 +24
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
TPCC could not compare KiteSQL and SQLite under the same durability setting, and primary-key point lookups opened a new LMDB cursor per key.
Issue link:
What is changed and how it works?
DataBaseBuilder::sync(RocksDB sync writes / LMDBNO_SYNC) and a tpcc--syncflag shared by all backends, replacing the SQLite-only--sqlite-profile.tpcc-sqlite-practical/tpcc-sqlite-balancedmake targets accordingly.Transaction::point_cursor/get_at).Code changes
Check List
Tests
Side effects
Note for reviewer
make testpasses (517 tests) and all SLT files pass; the lookup path is covered by existing index-scan tests.--sqlite-profileis removed; use--syncinstead (default off).