Skip to content

Fix SQL semantics and add VARBINARY - #390

Merged
KKould merged 10 commits into
mainfrom
fix/sql-semantics
Oct 25, 2026
Merged

KKould merged 10 commits into
mainfrom
fix/sql-semantics

fix: return an error for SUM/AVG over non-numeric types instead of as…

e3dc1d3
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 25, 2026 in 0s

93.53% (-0.16%) compared to c78efe9

View this Pull Request on Codecov

93.53% (-0.16%) compared to c78efe9

Details

Codecov Report

❌ Patch coverage is 92.46032% with 38 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.53%. Comparing base (c78efe9) to head (e3dc1d3).

Files with missing lines Patch % Lines
src/types/value.rs 80.00% 7 Missing ⚠️
src/binder/parser.rs 94.82% 6 Missing ⚠️
src/binder/expr.rs 50.00% 4 Missing ⚠️
src/orm/mod.rs 62.50% 3 Missing ⚠️
src/types/evaluator/date.rs 40.00% 3 Missing ⚠️
src/types/evaluator/datetime.rs 40.00% 3 Missing ⚠️
src/types/evaluator/time32.rs 57.14% 3 Missing ⚠️
src/types/evaluator/time64.rs 70.00% 3 Missing ⚠️
src/binder/select.rs 96.92% 2 Missing ⚠️
src/types/evaluator/bytes.rs 85.71% 1 Missing ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #390      +/-   ##
==========================================
- Coverage   93.68%   93.53%   -0.16%     
==========================================
  Files         260      260              
  Lines       48783    34412   -14371     
==========================================
- Hits        45704    32188   -13516     
+ Misses       3079     2224     -855     
Files with missing lines Coverage Δ
src/binder/aggregate.rs 97.26% <100.00%> (-0.75%) ⬇️
src/binder/create_table.rs 76.66% <ø> (-11.01%) ⬇️
src/binder/distinct.rs 98.66% <ø> (-0.60%) ⬇️
src/binder/mod.rs 84.42% <ø> (-2.33%) ⬇️
src/catalog/column.rs 89.58% <ø> (-1.28%) ⬇️
src/catalog/table.rs 98.43% <ø> (-0.36%) ⬇️
src/db.rs 95.98% <100.00%> (+2.56%) ⬆️
src/db/prepared.rs 93.47% <100.00%> (-1.08%) ⬇️
src/execution/dml/analyze.rs 95.45% <ø> (-2.56%) ⬇️
src/execution/dml/copy_from_file.rs 96.61% <ø> (-0.89%) ⬇️
... and 89 more

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.