fix(code-review): group council findings by line instead of lossy dedup#4620
Open
St0rmz1 wants to merge 1 commit into
Open
fix(code-review): group council findings by line instead of lossy dedup#4620St0rmz1 wants to merge 1 commit into
St0rmz1 wants to merge 1 commit into
Conversation
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryThis PR only changes coordinator prompt text (grouping same-line council findings instead of lossy dedup) and an accompanying summary-table note, with matching test coverage; no logic, security, or correctness issues found in the changed lines. Files Reviewed (4 files)
Reviewed by claude-sonnet-5 · Input: 20 · Output: 3.3K · Cached: 402.1K Review guidance: REVIEW.md from base branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Code Reviewer Council coordinator was told to "merge duplicate findings that
land on the same file and line." When two specialists flagged the same line for
different reasons (for example a security issue and a logic error), that
instruction collapsed them into one and could drop a finding or lower its
severity. This changes the instruction to group by line instead of dedup: one
inline comment per line that lists each specialist's finding, keeps the highest
severity, and drops nothing.
Changes
council-prompt.ts): replace the "merge duplicatefindings on the same file and line" step with a grouping step. Findings that
share a
file:lineare posted as one inline comment that lists eachspecialist separately (name, severity, rationale), the header severity is the
highest in the group (no downgrade), findings on different lines stay separate
comments, and no finding is discarded.
code-review-council.ts): add a note under theper-specialist table explaining that findings are counted per specialist and
same-line findings are grouped into one comment, so the raw total reads higher
than the inline-comment count by design.
council-prompt.test.ts,code-review-council.test.ts).Verification
Ran a council review against a test pull request with intentional issues in
provider mode and confirmed on the posted comments:
correctness issue on the same line) produced one inline comment listing
both, neither dropped, header severity critical.
all four, header severity critical (the max), not downgraded.
per-specialist total vs the grouped inline-comment count).
Visual Changes
N/A (no application UI). The change affects the content of the posted PR inline
comments and the council summary note.
Reviewer Notes
the posted comments. It is no longer lossy (nothing dropped, severity
preserved), but still formatted by the model. A fully code-owned version
(code posts the grouped inline comments itself) is a possible follow-up.
buildCouncilOrchestratorPrompt(
council-prompt.ts), specifically that it replaces dedup withgroup-and-list and mandates max severity with no dropped findings.