Skip to content

feat(gastown): add REVIEW.md support to refinery code review prompts #3608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
IamCoder18 wants to merge 1 commit into
base: main
Choose a base branch
from
+18 −14
Open

feat(gastown): add REVIEW.md support to refinery code review prompts #3608

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 18 additions & 14 deletions services/gastown/src/prompts/refinery-system.prompt.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,13 +73,15 @@ ${gateList}

### Step 2: Code Review
If all gates pass (or no gates are configured), review the diff:
1. Run \`git diff ${params.targetBranch}...HEAD\` to see all changes
2. Check for:
- Correctness — does the code do what the bead title/description asked?
- Style — consistent with the existing codebase?
- Test coverage — are new features tested?
- Security — no secrets, no injection vulnerabilities, no unsafe patterns?
- Build artifacts — no compiled files, node_modules, or other generated content?

- First, check for REVIEW.md in the workspace root. If it exists, read and follow its guidance for what to flag, severity calibration, skip rules, and summary format.
- If REVIEW.md is absent, use these default review rules:
- Correctness — does the code do what the bead title/description asked?
- Style — consistent with the existing codebase?
- Test coverage — are new features tested?
- Security — no secrets, no injection vulnerabilities, no unsafe patterns?
- Build artifacts — no compiled files, node_modules, or other generated content?
- Then, run \`git diff ${params.targetBranch}...HEAD\` to see all changes

### Step 3: Decision

Expand Down Expand Up @@ -197,13 +199,15 @@ ${params.gateList}

### Step 2: Code Review
Review the diff on the PR:
1. Run \`gh pr diff ${params.prUrl}\` or \`git diff ${params.targetBranch}...HEAD\` to see all changes
2. Check for:
- Correctness — does the code do what the bead title/description asked?
- Style — consistent with the existing codebase?
- Test coverage — are new features tested?
- Security — no secrets, no injection vulnerabilities, no unsafe patterns?
- Build artifacts — no compiled files, node_modules, or other generated content?

- First, check for REVIEW.md in the workspace root. If it exists, read and follow its guidance for what to flag, severity calibration, skip rules, and summary format.
- If REVIEW.md is absent, use these default review rules:
- Correctness — does the code do what the bead title/description asked?
- Style — consistent with the existing codebase?
- Test coverage — are new features tested?
- Security — no secrets, no injection vulnerabilities, no unsafe patterns?
- Build artifacts — no compiled files, node_modules, or other generated content?
- Then, run \`gh pr diff ${params.prUrl}\` or \`git diff ${params.targetBranch}...HEAD\` to see all changes

### Step 3: Submit Your Review

Expand Down