Skip to content

fix(dev): wire gastown wasteland services#3565

Open
jrf0110 wants to merge 2 commits into
mainfrom
fix-gt-wl-dev
Open

fix(dev): wire gastown wasteland services#3565
jrf0110 wants to merge 2 commits into
mainfrom
fix-gt-wl-dev

Conversation

@jrf0110
Copy link
Copy Markdown
Contributor

@jrf0110 jrf0110 commented May 28, 2026

Summary

  • Register the wasteland Cloudflare worker in the local dev CLI so dev:start can discover and launch it under the gastown group.
  • Align local public gastown/wasteland URLs with their Cloudflare service names and dev ports.
  • Add an explicit wasteland wrangler dev port and keep local env files ignored.

Verification

  • Not run locally; this shell initially lacked node/pnpm, so the pre-push checks could not execute before the explicitly approved --no-verify push.

Visual Changes

N/A

Reviewer Notes

  • Review the expected gastown dev port change from 8803 to 8810 in apps/web/.env.development.local.example against the current services/gastown/wrangler.jsonc configuration.


# @url cloudflare-gastown
NEXT_PUBLIC_GASTOWN_URL=http://localhost:8803
NEXT_PUBLIC_GASTOWN_URL=http://localhost:8810
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WARNING: Port mismatch — NEXT_PUBLIC_GASTOWN_URL is set to 8810 here, but services/gastown/wrangler.jsonc declares dev.port: 8803. Port 8810 is already assigned to kiloclaw-inbound-email (services/kiloclaw-inbound-email/wrangler.jsonc), creating a collision.

The # @url cloudflare-gastown annotation causes env-sync to auto-resolve this URL to the port read from services/gastown/wrangler.jsonc (i.e. 8803), so the generated .env.development.local will use 8803 — but the hardcoded example default is misleading and incorrect. This should be 8803 to match the actual wrangler config.

Suggested change
NEXT_PUBLIC_GASTOWN_URL=http://localhost:8810
NEXT_PUBLIC_GASTOWN_URL=http://localhost:8803

"compatibility_flags": ["nodejs_compat"],
"placement": { "mode": "smart" },
"dev": {
"port": 8796
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WARNING: Port 8796 is already assigned to services/security-sync/wrangler.jsonc. While cloudflare-security-sync is not currently registered in dev/local/services.ts and won't conflict during normal local dev, this is a port collision in wrangler configs. If security-sync is ever added to local dev or run manually alongside wasteland, both services will attempt to bind port 8796. Consider assigning a unique port (e.g. 8812 or another unassigned value).

@kilo-code-bot
Copy link
Copy Markdown
Contributor

kilo-code-bot Bot commented May 28, 2026

Code Review Summary

Status: 2 Issues Found | Recommendation: Address before merge

Executive Summary

NEXT_PUBLIC_GASTOWN_URL references port 8810 (already owned by kiloclaw-inbound-email) instead of the actual gastown dev port 8803; and wasteland shares dev port 8796 with security-sync.

Overview

Severity Count
CRITICAL 0
WARNING 2
SUGGESTION 0
Issue Details (click to expand)

WARNING

File Line Issue
apps/web/.env.development.local.example 51 NEXT_PUBLIC_GASTOWN_URL hardcoded to port 8810 (owned by kiloclaw-inbound-email); gastown wrangler config is 8803. env-sync auto-resolves via @url to 8803, but the example default is misleading.
services/wasteland/wrangler.jsonc 9 Dev port 8796 collides with services/security-sync/wrangler.jsonc. No immediate local-dev conflict since security-sync isn't in services.ts, but risks a bind conflict if it's ever added.
Notes on the `--ip 0.0.0.0` removal (gastown package.json)

Removing --ip 0.0.0.0 from the dev/start scripts in services/gastown/package.json is correct — dev/local/services.ts already injects --ip 0.0.0.0 at lines 479–480 when launching the worker, so the flag was redundant in the npm script.

Files Reviewed (4 files)
  • apps/web/.env.development.local.example — 1 issue
  • dev/local/services.ts — no issues
  • services/gastown/package.json — no issues
  • services/wasteland/wrangler.jsonc — 1 issue

Fix these issues in Kilo Cloud


Reviewed by claude-sonnet-4.6 · 2,070,107 tokens

Review guidance: REVIEW.md from base branch main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant