fix(dev): wire gastown wasteland services#3565
Conversation
|
|
||
| # @url cloudflare-gastown | ||
| NEXT_PUBLIC_GASTOWN_URL=http://localhost:8803 | ||
| NEXT_PUBLIC_GASTOWN_URL=http://localhost:8810 |
There was a problem hiding this comment.
WARNING: Port mismatch — NEXT_PUBLIC_GASTOWN_URL is set to 8810 here, but services/gastown/wrangler.jsonc declares dev.port: 8803. Port 8810 is already assigned to kiloclaw-inbound-email (services/kiloclaw-inbound-email/wrangler.jsonc), creating a collision.
The # @url cloudflare-gastown annotation causes env-sync to auto-resolve this URL to the port read from services/gastown/wrangler.jsonc (i.e. 8803), so the generated .env.development.local will use 8803 — but the hardcoded example default is misleading and incorrect. This should be 8803 to match the actual wrangler config.
| NEXT_PUBLIC_GASTOWN_URL=http://localhost:8810 | |
| NEXT_PUBLIC_GASTOWN_URL=http://localhost:8803 |
| "compatibility_flags": ["nodejs_compat"], | ||
| "placement": { "mode": "smart" }, | ||
| "dev": { | ||
| "port": 8796 |
There was a problem hiding this comment.
WARNING: Port 8796 is already assigned to services/security-sync/wrangler.jsonc. While cloudflare-security-sync is not currently registered in dev/local/services.ts and won't conflict during normal local dev, this is a port collision in wrangler configs. If security-sync is ever added to local dev or run manually alongside wasteland, both services will attempt to bind port 8796. Consider assigning a unique port (e.g. 8812 or another unassigned value).
Code Review SummaryStatus: 2 Issues Found | Recommendation: Address before merge Executive Summary
Overview
Issue Details (click to expand)WARNING
Notes on the `--ip 0.0.0.0` removal (gastown package.json)Removing Files Reviewed (4 files)
Fix these issues in Kilo Cloud Reviewed by claude-sonnet-4.6 · 2,070,107 tokens Review guidance: REVIEW.md from base branch |
Summary
dev:startcan discover and launch it under the gastown group.Verification
node/pnpm, so the pre-push checks could not execute before the explicitly approved--no-verifypush.Visual Changes
N/A
Reviewer Notes
8803to8810inapps/web/.env.development.local.exampleagainst the currentservices/gastown/wrangler.jsoncconfiguration.