Skip to content

docs(email): add migration plan for NeverBounce → Bouncer#2323

Open
alexkgold wants to merge 1 commit intomainfrom
plan/neverbounce-to-bouncer
Open

docs(email): add migration plan for NeverBounce → Bouncer#2323
alexkgold wants to merge 1 commit intomainfrom
plan/neverbounce-to-bouncer

Conversation

@alexkgold
Copy link
Copy Markdown
Contributor

Summary

  • Adds .plans/neverbounce-to-bouncer.md documenting the full plan to replace NeverBounce with Bouncer for email verification
  • Covers API differences, block logic decisions (allow risky, block undeliverable and domain.disposable === 'yes'), timeout tradeoffs, all files to change, test rewrite scope, and secrets rotation steps

Verification

N/A — docs-only change.

Visual Changes

N/A

Reviewer Notes

The plan flags a timeout decision that needs input before implementation: keep the current 5s client timeout (fail-open on slow Bouncer responses) vs. raise to 10s for better detection at the cost of slower magic-link UX for affected addresses.

`'Email blocked by NeverBounce verification...'` →
`'Email blocked by Bouncer verification. This address is undeliverable or disposable.'`

### 6. `apps/web/src/lib/kiloclaw/billing-lifecycle-cron.ts`
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WARNING: This section points to the wrong billing worker file

neverbounce_rejected is still part of the SendResult.reason union in services/kiloclaw-billing/src/lifecycle.ts:55, so the migration plan also needs to update that worker contract. As written, this sends implementers to apps/web/src/lib/kiloclaw/billing-lifecycle-cron.ts, which does not exist, and risks leaving a compile error behind when email.ts starts returning bouncer_rejected.

@kilo-code-bot
Copy link
Copy Markdown
Contributor

kilo-code-bot bot commented Apr 11, 2026

Code Review Summary

Status: 1 Issues Found | Recommendation: Address before merge

Overview

Severity Count
CRITICAL 0
WARNING 1
SUGGESTION 0

Fix these issues in Kilo Cloud

Issue Details (click to expand)

WARNING

File Line Issue
.plans/neverbounce-to-bouncer.md 120 Plan references a non-existent billing worker path and misses the real services/kiloclaw-billing/src/lifecycle.ts SendResult.reason update needed for the bouncer_rejected rename.
Other Observations (not in diff)

Issues found in unchanged code that cannot receive inline comments:

None.

Files Reviewed (1 files)
  • .plans/neverbounce-to-bouncer.md - 1 issue

Reviewed by gpt-5.4-20260305 · 278,297 tokens

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant