docs(email): add migration plan for NeverBounce → Bouncer#2323
Open
docs(email): add migration plan for NeverBounce → Bouncer#2323
Conversation
| `'Email blocked by NeverBounce verification...'` → | ||
| `'Email blocked by Bouncer verification. This address is undeliverable or disposable.'` | ||
|
|
||
| ### 6. `apps/web/src/lib/kiloclaw/billing-lifecycle-cron.ts` |
Contributor
There was a problem hiding this comment.
WARNING: This section points to the wrong billing worker file
neverbounce_rejected is still part of the SendResult.reason union in services/kiloclaw-billing/src/lifecycle.ts:55, so the migration plan also needs to update that worker contract. As written, this sends implementers to apps/web/src/lib/kiloclaw/billing-lifecycle-cron.ts, which does not exist, and risks leaving a compile error behind when email.ts starts returning bouncer_rejected.
Contributor
Code Review SummaryStatus: 1 Issues Found | Recommendation: Address before merge Overview
Fix these issues in Kilo Cloud Issue Details (click to expand)WARNING
Other Observations (not in diff)Issues found in unchanged code that cannot receive inline comments: None. Files Reviewed (1 files)
Reviewed by gpt-5.4-20260305 · 278,297 tokens |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.plans/neverbounce-to-bouncer.mddocumenting the full plan to replace NeverBounce with Bouncer for email verificationrisky, blockundeliverableanddomain.disposable === 'yes'), timeout tradeoffs, all files to change, test rewrite scope, and secrets rotation stepsVerification
N/A — docs-only change.
Visual Changes
N/A
Reviewer Notes
The plan flags a timeout decision that needs input before implementation: keep the current 5s client timeout (fail-open on slow Bouncer responses) vs. raise to 10s for better detection at the cost of slower magic-link UX for affected addresses.