Fix left shift on signed int channel setting sign bit and causing UB#28
Merged
MarkCallow merged 2 commits intoJul 15, 2026
Conversation
* When the signed integer (type: int) is 192, the following undefined behavior occurs: 11000000 << 24 => is undefined behavior because setting sign bit of an integer via a left shift operation is UB. Simply cast channel to uint32_t before shifting. * To replicate: build with -fsanitize="undefined" and navigate to KTX-Software/tests/cts/clitests then: ktx transcode --testrun input/ktx2/valid_R16G16_SFLOAT_CUBE_ARRAY.ktx2 / output/transcode/transcode_error_not_transcodable/output_R16G16_SFLOAT_CUBE_ARRAY.ktx2 You will get the following: KTX-Software/external/dfdutils/createdfd.c:123:18: runtime error: left shift of 192 by 24 places cannot be represented in type 'int' Signed-off-by: Walid Chtioui <walid.chtioui.main@gmail.com>
Collaborator
|
The |
Contributor
Author
|
Agree. That cast from |
MarkCallow
reviewed
Jul 14, 2026
Signed-off-by: Walid Chtioui <walid.chtioui.main@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't whether this was causing any issues, but:
When the signed integer (type: int) is 192, the following undefined behavior occurs: 11000000 << 24 => is undefined behavior because setting sign bit of an integer via a left shift operation is UB. Simply cast channel to uint32_t before shifting.
To replicate: build with -fsanitize="undefined" and navigate to KTX-Software/tests/cts/clitests then:
ktx transcode --testrun input/ktx2/valid_R16G16_SFLOAT_CUBE_ARRAY.ktx2 / output/transcode/transcode_error_not_transcodable/output_R16G16_SFLOAT_CUBE_ARRAY.ktx2
You will get the following:
KTX-Software/external/dfdutils/createdfd.c:123:18: runtime error: left shift of 192 by 24 places cannot be represented in type 'int'