layers: Add tile properties core checks - #12563
Conversation
|
Author ZZKQcom not on autobuild list. Waiting for curator authorization before starting CI build. |
|
@ZZKQcom I'm currently going to stop reviewing all these QCOM vendor extension until we first get VK_KHR_opacity_micromap code in as that is now a month behind and QCOM is on the hook for it, so feel free to either just wait or help with the |
|
@spencer-lunarg Appreciate the heads-up. I understand |
|
@ZZKQcom there is a PR open to get the state tracking in, after we get that in, I will create an issue with all the remaining VUs to add and you two can sort it out from there... If you plan to help, my advice is to get familiar with the VK_KHR_opacity_micromap extension (luckily Matt already gave a great presentation on it!) |
ac79620 to
1109522
Compare
|
Author ZZKQcom not on autobuild list. Waiting for curator authorization before starting CI build. |
1109522 to
f10b5ac
Compare
|
Author ZZKQcom not on autobuild list. Waiting for curator authorization before starting CI build. |
f10b5ac to
1843bc7
Compare
|
Author ZZKQcom not on autobuild list. Waiting for curator authorization before starting CI build. |
1843bc7 to
5904f1e
Compare
|
Author ZZKQcom not on autobuild list. Waiting for curator authorization before starting CI build. |
5904f1e to
360947c
Compare
|
Author ZZKQcom not on autobuild list. Waiting for curator authorization before starting CI build. |
|
@spencer-lunarg I've made significant changes to the begin rendering core checks. Could you find time to review when you're free? I believe the CPU validation work for |
360947c to
66caa01
Compare
|
Author ZZKQcom not on autobuild list. Waiting for curator authorization before starting CI build. |
66caa01 to
ea55a6b
Compare
|
Author ZZKQcom not on autobuild list. Waiting for curator authorization before starting CI build. |
ea55a6b to
9cd7d7d
Compare
|
Author ZZKQcom not on autobuild list. Waiting for curator authorization before starting CI build. |
9cd7d7d to
3010820
Compare
|
Author ZZKQcom not on autobuild list. Waiting for curator authorization before starting CI build. |
|
sorry I forgot about this PR, please rebase and can review again and help get it in |
3010820 to
a2464e4
Compare
|
Author ZZKQcom not on autobuild list. Waiting for curator authorization before starting CI build. |
|
@spencer-lunarg I still need to refactor and double-check the code, so please hold off on reviewing it for now; once it's ready, I'll send you a review request. Thank you! |
a2464e4 to
d7435a1
Compare
|
Author ZZKQcom not on autobuild list. Waiting for curator authorization before starting CI build. |
d7435a1 to
b9e801f
Compare
|
Author ZZKQcom not on autobuild list. Waiting for curator authorization before starting CI build. |
|
@spencer-lunarg The PR refactor is ready. Thanks! |
b9e801f to
71b2d5d
Compare
|
Author ZZKQcom not on autobuild list. Waiting for curator authorization before starting CI build. |
|
This PR change splits the Functions prefixed with Functions prefixed with
|
| return skip; | ||
| } | ||
|
|
||
| const LogObjectList objlist(commandBuffer, view_state.Handle()); |
There was a problem hiding this comment.
It needs view_state->Handle(), but we already added in ValidateRenderingInfoFragmentShadingRate function, and only ValidateRenderingInfoFragmentShadingRate function will invoke ValidateRenderingInfoFragmentShadingRateRenderArea function.
So I removed it.
71b2d5d to
9de2829
Compare
|
Author ZZKQcom not on autobuild list. Waiting for curator authorization before starting CI build. |
9de2829 to
a88f26c
Compare
|
Author ZZKQcom not on autobuild list. Waiting for curator authorization before starting CI build. |
| vku::FindStructInPNextChain<VkRenderingFragmentDensityMapAttachmentInfoEXT>(rendering_info.pNext); | ||
|
|
||
| if (fragment_density_map_info && fragment_density_map_info->imageView != VK_NULL_HANDLE && has_rp_enable_bit) { | ||
| const LogObjectList objlist(cb_state.Handle(), fragment_density_map_info->imageView); |
There was a problem hiding this comment.
the new objlist doesn't include the fragment density map Image View
... this whole PR is not in any state I would be happy to merge it as it just clobbers all the previous DynamicRendering to shove in this vkGetDynamicRenderingTilePropertiesQCOM logic
If we want to make any progress on this, I would suggest just keeping this PR open, but make a new PR that just replaces the const LogObjectList& objlist you are planning to do in this PR and maybe once we get at least that done, this PR can be unraveled a ibt
There was a problem hiding this comment.
Thanks for flagging the missing image view and invasiveness, I'll open a small refactoring to parameterize LogObjectList first and then streamline this change.
3 participants
Overview
vkGetDynamicRenderingTilePropertiesQCOMnow triggers the same core VUIDs defined onVkRenderingInfoasvkCmdBeginRendering.This change extracts the command-buffer-independent
VkRenderingInfovalidation fromPreCallValidateCmdBeginRenderinginto a new shared helperValidateRenderingInfoCommon, with functions renamed fromValidateBeginRendering*toValidateRenderingInfo*and signatures changed fromVkCommandBuffertoconst LogObjectList&.ValidateBeginRenderingColorAttachment,ValidateBeginRenderingDepthAttachment, andValidateBeginRenderingStencilAttachmentare intentionally excluded, they check current image layout tracked in command buffer state.ValidateBeginRenderingTileShadingCreateInfois also excluded, it needs command buffer begin flags.Unit Tests
DynamicRenderingTilePropertiesWithInvalidFragmentDensityMapUsageVUID VkRenderingFragmentDensityMapAttachmentInfoEXT-imageView-06158DynamicRenderingTilePropertiesWithInvalidFragmentShadingRateUsageVUID VkRenderingFragmentShadingRateAttachmentInfoKHR-imageView-06148DynamicRenderingTilePropertiesWithInvalidMultisampledRenderToSingleSampledInfoVUID VkMultisampledRenderToSingleSampledInfoEXT-rasterizationSamples-06878DynamicRenderingTilePropertiesWithTileShadingAndFragmentDensityMapVUID-VkRenderingInfo-imageView-10643DynamicRenderingTilePropertiesWithResolveAttachmentBoundToTileMemoryVUID-VkRenderingAttachmentInfo-resolveImageView-10728