Unify vkb::ShaderModule and vkb::core::HPPShaderModule into vkb::core::ShaderModule<bindingType> - #1556
Unify vkb::ShaderModule and vkb::core::HPPShaderModule into vkb::core::ShaderModule<bindingType>#1556asuessenbach wants to merge 2 commits into
Conversation
b8689b5 to
aab508d
Compare
|
I'm hitting 2 problems: [error] Error Message: unordered_map::at followed by: |
|
@tomek-brcm Thanks for spotting this failure. Fix was easy, I've no idea how that could have slept through. Besides that, this PR now fixes an error I get with 2 samples on main: hpp_pipeline_cache: pipeline_cache: |
The merge-base changed after approval.
The merge-base changed after approval.
…::ShaderModule<bindingType>
af649ce to
06c79e5
Compare
|
Tested on Android and I'm seeing the same error as Tomek: [error] Error Message: unordered_map::at: key not found None of the samples work. Maybe the last force push pushed a wrong/old commit? |
d96133e to
65234f9
Compare
|
@SaschaWillems You're right, that was wrong, somehow. Hopefully, it's really fixed now (fingers crossed!) Could you please re-check? |
SaschaWillems
left a comment
There was a problem hiding this comment.
Thanks.
This is now working as expected. Tested on Android 17 with a Google Pixel 9.
Description
Next unified class on C- and C++-bindings.
Comes together with unification of
vkb::ShaderResourceType,vkb::ShaderResourceMode,vkb::ShaderResourceQualifiers,vkb::ShaderResource,vkb::ShaderVariant,vkb::ShaderSource, andvkb::SPIRVReflection.Build tested on Win11 with VS2026. Run tested on Win11 with NVidia GPU.
General Checklist:
Please ensure the following points are checked:
Note: The Samples CI runs a number of checks including:
If this PR contains framework changes:
batchcommand line argument to make sure all samples still work properlySample Checklist
If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist: