Refactor device extension handling - #1552
Conversation
3abef20 to
a82f6ef
Compare
|
Nit: VK_EXT_DEBUG_MARKER_EXTENSION_NAME is now requested unconditionally (as Optional) in the base request_device_extensions(), whereas before it was only added once the code had already confirmed debug_utils wasn't set via VK_EXT_DEBUG_UTILS. This is harmless (Optional, so no failure) but can enable an unused device extension when debug-utils is already active via the instance extension — a minor cleanliness nit, not a bug. |
Good point. |
236be2a to
c06fc75
Compare
The merge-base changed after approval.
|
Vulkan-Samples/samples/api/swapchain_present_timing/swapchain_present_timing.cpp:814:9: error: 'add_device_extension' was not declared in this scope; did you mean 'request_device_extensions'? |
1b59412 to
16c1689
Compare
|
@tomek-brcm I'm sorry, that was a rebase/merge issue. Should be fixed now. |
40aff03 to
ed5786a
Compare
ed5786a to
9e5768f
Compare
SaschaWillems
left a comment
There was a problem hiding this comment.
Successfully tested on Android 17 with a Google Pixel 9.
Description
Similar to what we've done in #1455, I refactored the device extension handling.
Instead of the
add_device_extensionandget_device_extensionsfunctions, we now have arequest_device_extensions, exactly like we already have arequest_instance_extensions.Build tested on Win11 with VS2026. Run tested on Win11 with NVidia GPU.
General Checklist:
Please ensure the following points are checked:
Note: The Samples CI runs a number of checks including:
If this PR contains framework changes:
batchcommand line argument to make sure all samples still work properlySample Checklist
If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist: