Skip to content

Fix layer settings for shader_debugPrintf and reenable iOS Simulator execution#1498

Merged
marty-johnson59 merged 6 commits intoKhronosGroup:mainfrom
SRSaunders:fix-layer-settings
Mar 9, 2026
Merged

Fix layer settings for shader_debugPrintf and reenable iOS Simulator execution#1498
marty-johnson59 merged 6 commits intoKhronosGroup:mainfrom
SRSaunders:fix-layer-settings

Conversation

@SRSaunders
Copy link
Contributor

@SRSaunders SRSaunders commented Mar 2, 2026

Description

This PR contains the following:

  1. Fixes a layer settings regression in the shader_debugPrintf sample for Release builds - all platforms.
  2. Addresses a layer settings holdover problem in the Vulkan Samples framework when running in batch mode - all platforms.
  3. Corrects a reversed DebugUtils and DebugReport callback setup in get_instance_create_info_extensions() - all platforms.
  4. Re-enables samples to run on the iOS Simulator target by fixing a regression in the framework that incorrectly made VK_KHR_portability_enumeration mandatory - should be optional.
  5. Completes the new layer settings framework transition work to allow layout_transitions, pipeline_barriers, and subpasses to compile and run for the iOS Simulator target.

Fixes #1496 and #1497.

Tested with Vulkan SDK 1.4.341 on: a) Windows 11, b) macOS Sequoia 15.7.4 (MoltenVK and KosmicKrisp), and c) iOS 26.2 on iOS Simulator.

General Checklist:

Please ensure the following points are checked:

  • My code follows the coding style
  • I have reviewed file licenses
  • I have commented any added functions (in line with Doxygen)
  • I have commented any code that could be hard to understand
  • My changes do not add any new compiler warnings
  • My changes do not add any new validation layer errors or warnings
  • I have used existing framework/helper functions where possible
  • My changes do not add any regressions
  • I have tested every sample to ensure everything runs correctly
  • This PR describes the scope and expected impact of the changes I am making

Note: The Samples CI runs a number of checks including:

  • I have updated the header Copyright to reflect the current year (CI build will fail if Copyright is out of date)
  • My changes build on Windows, Linux, macOS and Android. Otherwise I have documented any exceptions

If this PR contains framework changes:

  • I did a full batch run using the batch command line argument to make sure all samples still work properly

Sample Checklist

If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist:

  • I have tested the sample on at least one compliant Vulkan implementation
  • If the sample is vendor-specific, I have tagged it appropriately
  • I have stated on what implementation the sample has been tested so that others can test on different implementations and platforms
  • Any dependent assets have been merged and published in downstream modules
  • For new samples, I have added a paragraph with a summary to the appropriate chapter in the readme of the folder that the sample belongs to e.g. api samples readme
  • For new samples, I have added a tutorial README.md file to guide users through what they need to know to implement code using this feature. For example, see conditional_rendering
  • For new samples, I have added a link to the Antora navigation so that the sample will be listed at the Vulkan documentation site

Copy link
Contributor

@asuessenbach asuessenbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catches!

Thanks a lot for the corrections.

@marty-johnson59 marty-johnson59 merged commit 83e0991 into KhronosGroup:main Mar 9, 2026
19 checks passed
@SRSaunders SRSaunders deleted the fix-layer-settings branch March 10, 2026 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

shader_debugPrintf sample fails in release builds and in batch mode

5 participants