x11: add x11 and xrandr headers correctly#1869
x11: add x11 and xrandr headers correctly#1869charles-lunarg merged 1 commit intoKhronosGroup:mainfrom
Conversation
x11 depends on xorgproto headers. Use `X11_INCLUDE_DIRS` populated by pkg_check_modules properly add the xproto headers to the include search path, because `X11_INCLUDE_DIRS` also takes care of the transitive dependencies, while the original `includedir` variable doesn't. The same applies to the xrandr headers.
|
Author 06393993 not on autobuild list. Waiting for curator authorization before starting CI build. |
1 similar comment
|
Author 06393993 not on autobuild list. Waiting for curator authorization before starting CI build. |
|
|
|
I know that I am just wondering if the upstream could accept this PR so that we don't diverge from the upstream. Thanks. |
|
CI Vulkan-Loader build queued with queue ID 660865. |
charles-lunarg
left a comment
charles-lunarg
left a comment
There was a problem hiding this comment.
As long as CI is happy, this seems like a no brainer.
|
CI Vulkan-Loader build # 3435 running. |
|
CI Vulkan-Loader build # 3435 passed. |
4 participants
x11 depends on xorgproto headers. Use
X11_INCLUDE_DIRSpopulated by pkg_check_modules properly add the xproto headers to the include search path, becauseX11_INCLUDE_DIRSalso takes care of the transitive dependencies, while the originalincludedirvariable doesn't.The same applies to the xrandr headers.