Skip to content

Fix and make LocalFilesystemResource.write consistent with the other FS (GCS, S3)#566

Merged
tramora merged 1 commit intomainfrom
557-create-target-directory-if-missing
Apr 9, 2026
Merged

Fix and make LocalFilesystemResource.write consistent with the other FS (GCS, S3)#566
tramora merged 1 commit intomainfrom
557-create-target-directory-if-missing

Conversation

@tramora
Copy link
Copy Markdown
Collaborator

@tramora tramora commented Mar 23, 2026

Before writing the target file, if a folder is missing in the file path, it is automatically created

Fixes #557


TODO Before Asking for a Review

  • Rebase your branch to the latest version of main (or main-v10)
  • Make sure all CI workflows are green
  • When adding a public feature/fix: Update the Unreleased section of CHANGELOG.md (no date)
  • Self-Review: Review "Files Changed" tab and fix any problems you find
  • API Docs (only if there are changes in docstrings, rst files or samples):
    • Check the docs build without warning: see the log of the API Docs workflow
    • Check that your changes render well in HTML: download the API Docs artifact and open index.html
    • If there are any problems it is faster to iterate by building locally the API Docs

@tramora tramora requested a review from popescu-v March 23, 2026 15:41
Copy link
Copy Markdown
Collaborator

@popescu-v popescu-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some code simplifications (see the comments), in the tests.

@tramora tramora force-pushed the 557-create-target-directory-if-missing branch from 72cc587 to 88e43eb Compare April 3, 2026 14:49
@tramora tramora requested a review from popescu-v April 3, 2026 14:59
…r FS (GCS, S3)

Before writing the target file, if a folder is missing in the file path, it is automatically created
@tramora tramora force-pushed the 557-create-target-directory-if-missing branch from 88e43eb to 853ef91 Compare April 6, 2026 16:26
@tramora tramora merged commit 17439c1 into main Apr 9, 2026
18 checks passed
@tramora tramora deleted the 557-create-target-directory-if-missing branch April 9, 2026 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

export_khiops_dictionary_file fails to export when directory does not exist

2 participants