Skip to content

Extract focused application grid policies #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KeyffMS wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Extract focused application grid policies #162

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f789ec1
Extract assignment grid columns mapping rendering and error policies
KeyffMS Sep 24, 2026
0e60de5
Delegate grid policies to focused collaborators
KeyffMS Sep 24, 2026
6fa1cfd
Use extracted grid error policy in tests/SightAdapt.Tests/Application…
KeyffMS Sep 24, 2026
60f9e86
Use extracted grid error policy in tests/SightAdapt.Tests/MenuVisualP…
KeyffMS Sep 24, 2026
ecd90f5
Test extracted assignment grid policies
KeyffMS Sep 24, 2026
639485c
Document extracted assignment grid policies
KeyffMS Sep 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions docs/ARCHITECTURE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,11 @@ A failed mutation or failed write does not replace committed settings and does n
| Target availability and frame positioning/source updates | availability strategies and `MagnifierFrameRenderer` |
| Native window/control lifetime | `MagnifierOverlay` |
| Notification-area presentation | `TrayPresenter` |
| Application-table presentation and edit mechanics | `ApplicationAssignmentsGrid` |
| Application-table selection, binding, row updates and typed publication | `ApplicationAssignmentsGrid` |
| Assignment-grid columns and selector options | `ApplicationAssignmentsGridColumns` |
| Assignment-grid cell-to-command mapping | `ApplicationAssignmentCellChangeMapper` |
| Assignment enabled-state painting | `ApplicationAssignmentEnabledCellRenderer` |
| Assignment selector data-error classification | `ApplicationAssignmentSelectorErrorPolicy` |
| Configuration use cases and dialogs | `ConfigurationForm` |
| Selector editing contract | `ModernSelectorEditingControl` |

Expand Down Expand Up @@ -179,7 +183,7 @@ Native menu detection, menu-overlay creation, and cross-filter refresh are subor

## Configuration grid boundary

`ApplicationAssignmentsGrid` owns columns, rows, selectors, status painting, selection, empty state, stable executable-path keys, separate typed change events, row updates, and failed-cell restoration. It does not know about persistence or dialogs.
`ApplicationAssignmentsGrid` remains the UserControl boundary and owns selection, binding, row updates, empty-state visibility, stable executable-path keys and typed change publication. Stable column/selector construction lives in `ApplicationAssignmentsGridColumns`; pure cell-to-command decoding lives in `ApplicationAssignmentCellChangeMapper`; enabled-state indicator geometry/painting lives in `ApplicationAssignmentEnabledCellRenderer`; selector data-error classification and diagnostics live in `ApplicationAssignmentSelectorErrorPolicy`. The grid does not know about persistence or dialogs.

`ConfigurationForm` resolves current committed assignments and translates typed grid events into domain-service mutations wrapped by `SettingsCoordinator.Commit`. It suppresses only its own synchronous full refresh during a grid-originated commit.

Expand Down
Loading
Loading