feat(report): add hover explanations and polish run/hunt report UI - #237
Conversation
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
WalkthroughThe pull request redesigns autonomous and shared HTML reports, updates report metadata and transcript behavior, standardizes non-suite labels as ChangesReport presentation
Estimated code review effort: 3 (Moderate) | ~25 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@core/src/autonomous/report/html.ts`:
- Around line 762-763: Update the Safety Score tooltip in
core/src/autonomous/report/html.ts lines 762-763 to say “scoreable findings”
instead of “scoreable threads,” and update the Findings tooltip at lines 771-772
to say “One entry per finding” instead of “One entry per attack thread.”
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 6beba5fa-7f74-4864-8ed2-bcbab4c063c2
📒 Files selected for processing (10)
core/src/autonomous/report/html.tscore/src/autonomous/report/types.tscore/src/execute/runAll.tscore/src/execute/runAllBrowser.tscore/src/execute/types.tscore/src/report/render.tsdocs/hunt.mdrunners/cli/src/commands/hunt.tsrunners/extension/popup.jsrunners/sdk/src/types.ts
Problem
Both report renderers (
opfor runandopfor hunt) had accumulated a set of UX and layout issues:--verify— implying verification happened when it didn't.Solution
Added a lightweight, reusable hover-tooltip system to both report renderers — a small "i" icon that shows an explanation the instant the pointer enters the card/row (not the ~1s native
titledelay), rather than always-on text cluttering the layout. Used it to explain every metric that isn't self-evident, and fixed the CSS bugs found while building it (bottom alignment viaspace-between, aninline-flexvsflexbug that silently broke margin math on the details toggle, and the badge/gauge optical alignment). Also fixed the Verifier row to omit itself entirely rather than show a misleading fallback, and moved the misplaced guardrails/weak-points data into its own section instead of implying it's live recon.Changes
Report renderers (
core/src/report/render.ts,core/src/autonomous/report/html.ts):.info-icon+.info-tooltip/.info-hover, triggered by hovering the whole card/row, not just the icon.space-between+ body wrapper), single-turn transcript left margin (.no-rail), details-toggle vertical centering (display:flex, notinline-flex), and the verdict-badge/gauge optical misalignment.--verifywasn't used, instead of falling back to the commander's model.Suite-label rename (
core/src/execute/runAll.ts,runAllBrowser.ts,core/src/execute/types.ts,runners/sdk/src/types.ts,runners/extension/popup.js): "Custom Suite" → "Custom" — three independent implementations of this label (Node run path, browser-extension path, and the extension's own display logic) all needed the same rename.CLI flag rename (
runners/cli/src/commands/hunt.ts,docs/hunt.md):--model→--commander-modelfor consistency with--operator-model/--scout-model.Docs:
core/src/autonomous/report/types.ts'sverifierModelcomment clarified to state it's only ever set when verification actually ran.Issue
N/A
How to test
Verified before every push:
tsc --noEmit(core/cli/sdk),eslint,prettier --check, andnpm test(277 passed / 0 failed) all clean, plus the full pre-commit pipeline (typecheck, lint, format, catalog build, skill validation, gitleaks) passed on commit.Screenshots
Verified visually via headless-Chrome screenshots at each step (exec-strip cell alignment, single-turn transcript margin, combined verdict tooltip with divider, severity/confidence tooltips rendering inline) rather than by inspection alone — not attached here, but every layout claim above was screenshot-checked before merging into this branch.
Summary by CodeRabbit
New Features
Updates
--modelto--commander-model.Documentation