fix(extension): stop iframe hangs and add debug mode - #229
Draft
arunSunnyKVS wants to merge 1 commit into
Draft
Conversation
chrome.scripting.executeScript({ allFrames: true }) could block forever on
unresponsive cross-origin frames; add timeouts with main-frame fallbacks,
raise snapshot depth for Draft.js widgets, and ship a debug-log UI for runs.
Co-authored-by: Cursor <cursoragent@cursor.com>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On pages with unresponsive cross-origin iframes (e.g. Google Maps embeds),
chrome.scripting.executeScript({ allFrames: true })could block forever. The extension hung at "Detecting chat widget…" / agent-context detection with no timeout or visibility into what failed.Separately, Chat360/Draft.js widgets nest message text deeper than the snapshot walker’s depth-15 limit, so bot replies were never extracted even when sends succeeded.
Solution
Promise.racetimeouts with main-frame-only fallbacks (collectFrames, AX snapshots, shadow patch, response scan, agent-context summarize).frame_snapshot.jscollect depth from 15 → 25 so deeply nested message bodies are captured.debugLog.js+ popup toggle / export / clear) that logs locate, LLM UI actions, send, and extract steps to the service worker + storage.frame_actuate.jsfailure details when submit is not accepted.Changes
runners/extension/debugLog.js(new)runners/extension/{agentContext,chatLocator,domActions,domTarget,frameDiscovery,frame_actuate,frame_snapshot,llm,llmUiActions,orchestrator,popup,responseExtractor,service_worker}.*Issue
N/A
How to test
runners/extensionin Chrome.Screenshots
N/A — debug toggle lives under Advanced settings in the side panel.
Made with Cursor