Skip to content

Fix vector add example runtime validation #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cherubrock-seb wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix vector add example runtime validation #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions examples/vector_add/main.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,13 +30,14 @@ template<int items_per_thread>
void run_kernel(int n) {
double constant = 1.0;
std::vector<half> input(n);
std::vector<float> output_expected;
std::vector<float> output_result;
std::vector<float> output_expected(n);
std::vector<float> output_result(n);

// Generate input data
for (int i = 0; i < n; i++) {
input[i] = half(i);
output_expected[i] = float(i + constant);
output_expected[i] =
float(half(float(input[i]) * float(input[i]) + float(half(constant))));
}

// Allocate device memory
Expand All @@ -59,7 +60,7 @@ void run_kernel(int n) {
kf::make_vec_ptr(output_dev));

// Copy results back
cuda_check(cudaMemcpy(output_dev, output_result.data(), sizeof(float) * n, cudaMemcpyDefault));
cuda_check(cudaMemcpy(output_result.data(), output_dev, sizeof(float) * n, cudaMemcpyDefault));

// Check results
for (int i = 0; i < n; i++) {
Expand Down
9 changes: 5 additions & 4 deletions examples/vector_add_tiling/main.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,13 +33,14 @@ template<int items_per_thread, int block_size = 256>
void run_kernel(int n) {
double constant = 1.0;
std::vector<half> input(n);
std::vector<float> output_expected;
std::vector<float> output_result;
std::vector<float> output_expected(n);
std::vector<float> output_result(n);

// Generate input data
for (int i = 0; i < n; i++) {
input[i] = half(i);
output_expected[i] = float(i + constant);
output_expected[i] =
float(half(float(input[i]) * float(input[i]))) * float(constant);
}

// Allocate device memory
Expand All @@ -58,7 +59,7 @@ void run_kernel(int n) {
<<<grid_size, block_size>>>(n, input_dev, constant, output_dev);

// Copy results back
cuda_check(cudaMemcpy(output_dev, output_result.data(), sizeof(float) * n, cudaMemcpyDefault));
cuda_check(cudaMemcpy(output_result.data(), output_dev, sizeof(float) * n, cudaMemcpyDefault));

// Check results
for (int i = 0; i < n; i++) {
Expand Down