Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CI here builds the Catch2 tests but runs only
~[GPU], because the hosted runners have no GPU, so the GPU-tagged tests never run. This adds a separate, optional workflow.github/workflows/gpu-sim.ymlthat builds the tests and runs them on a simulated NVIDIA H100, using PantheonSim (via thepantheongpu/setup-pantheonsimaction, pinned by SHA). I am the author of PantheonSim, so please weigh this accordingly.It does not touch the existing workflows and is not meant to be a required check. A simulator cannot reproduce hardware-specific behavior or timing, so it complements real-GPU testing and does not replace it.
What it does:
CMAKE_CUDA_ARCHITECTURES=90-virtualandCMAKE_CUDA_RUNTIME_LIBRARY=Shared(the simulator runs PTX only and needs a shared CUDA runtime), and builds with-j3.kernel_float_teststhroughvgpu run, including the GPU-tagged tests, then runs thepiexample.workflow_dispatchandpull_requesttomain, limited toinclude/,tests/,examples/,CMakeLists.txtand the workflow itself. A concurrency group cancels superseded runs, withpermissions: contents: read.What is left out, with the reason in comments in the file:
binary operatorsandconstant eq testsfor__nv_bfloat16(the simulator compares.bf16values by raw bits insetp, a known simulator bug),ternary operatorsfor__half(the referencex * y + zcompiles tomul.f16andadd.f16without a rounding modifier; on an RTX 3060 they are fused into an fma, the simulator rounds twice, so the last bit can differ) andternary operatorsfor__nv_bfloat16(this one also fails on an RTX 3060, sm_86, so it is not a simulator difference).vector_addandvector_add_tilingexamples are not run: they index emptystd::vectors (output_expected[i]andoutput_resultare never sized) and segfault on an RTX 3060 as well. I did not change them here.Side observation, not touched by this PR: on an RTX 3060 (sm_86, CUDA 13.0, Release) the
cache modifiertests for all five types fail with error 717 (illegal memory address) when run on their own, while they pass on the simulator.Result on a fork: the run passed. 177 of 181 test cases ran and all passed (
All tests passed (5264 assertions in 177 test cases)), and thepiexample ran. The job took about 13.7 minutes on a cold run, of which about 12.3 minutes was the action setting up the simulator on its first run. The build took about 1 minute and the tests and the example a few seconds.Run: https://github.com/saqibkh/kernel_float/actions/runs/42659400821