Skip to content

Fix TellC hashmap cleanup and macOS PR validation - #23

Merged
Neonwave175 merged 2 commits into
mainfrom
fix/tellc-hashmap-cleanup-and-macos-ci
Nov 19, 2026
Merged

Neonwave175 merged 2 commits into
mainfrom
fix/tellc-hashmap-cleanup-and-macos-ci

Conversation

@KernelGhost-gif

Copy link
Copy Markdown
Owner

Summary

This addresses the three follow-up findings from the review of PRs #21 and #22.

1. TellC hashmap lifetime

  • Register each allocated hashmap exactly once using an intrusive link in the table header. Aliases do not create additional ownership records.
  • On normal program return and uncaught Tell runtime errors, walk the registry and free every remaining entry node, bucket array, and table header.
  • Removed entries and old bucket arrays freed during growth remain compatible with final cleanup.
  • Add stress fixtures for repeated variable overwrite, nested maps and aliases.
  • Run both success and uncaught-error fixtures under Valgrind Memcheck in Linux CI.

The cleanup owns hashmap storage only. Text-key backing memory, list buffers, and other objects referenced as values retain their separately defined ownership rules.

2. macOS compiler validation

  • Add Apple Silicon external-LLVM build/test to pull-request validation.
  • Enable the existing Intel external-LLVM job on pull requests as well.
  • Keep the expensive source-built embedded LLVM + LLD Apple Silicon job weekly/manual.
  • Install Valgrind in the Linux TellC job so the new memory lifecycle checks execute in CI.

3. Benchmark and docs

  • Replace the stale JIT benchmark figures with the latest successful PR Add TellC hashmaps and portable standard libraries #22 benchmark run.
  • Record the exact runner, Go version, and link to the successful Actions run.
  • Fix the malformed benchmark command in docs/EXECUTION_ENGINES.md.
  • Update TellC CI/testing documentation and hashmap lifecycle notes.

Validation expected

The PR should run Linux TellC + Valgrind, Apple Silicon external LLVM, Intel macOS external LLVM, and the existing native/runtime checks. The embedded Apple Silicon LLVM + LLD source build remains scheduled/manual to avoid making every PR rebuild LLVM from source.

@Neonwave175
Neonwave175 merged commit ffff5db into main Nov 19, 2026
7 checks passed
@KernelGhost-gif
KernelGhost-gif deleted the fix/tellc-hashmap-cleanup-and-macos-ci branch November 19, 2026 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants