docs: surface command mode as a core feature + soften Falco loader claim#66
Merged
Merged
Conversation
Two fixes prompted by review of how the work reads (not the code): - The "Implemented:" list never mentioned command/binary validation, so the capability shipped in #65 read as not-a-core-feature. Add explicit bullets for `--command` mode (verdict = your loader's exit code; the bundled validator is NOT used — tests the real userspace loader path) and the known-tricky kernel library. - Soften the overclaim "validates Falco's modern_bpf probe exactly as Falco's own loader runs it." bpfcompat mirrors libpman's loader contract (runtime-sized maps, helper-gated program variants, trial-probed iterators via a manifest); it does not run Falco's loader binary. Reworded in README and the Falco case study, pointing at command mode as the way to run that exact binary. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #65 — fixes how the work reads, not the code.
1. Command mode wasn't surfaced as a core feature
The README "Implemented:" list led with
.bpf.ovalidation and never mentionedbpfcompat test --command, so the binary/loader-path capability (which #65actually shipped) read as missing. Added explicit bullets making clear:
loader path (distinct from
behaviormode, which layers a smoke command on topof a validator load);
2. Softened an overclaim
bpfcompat mirrors libpman's loader contract (runtime-sized maps, helper-gated
program variants, trial-probed iterators declared in a manifest) — it does not run
Falco's loader binary. Reworded in the README and the Falco case study, and point
at command mode as the way to run that exact binary.
Docs-only.
🤖 Generated with Claude Code