Skip to content

Fix inverted refresh margin in KaggleCredentials.access_token_has_expired #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kohbanye wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix inverted refresh margin in KaggleCredentials.access_token_has_expired #77

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions kagglesdk/kaggle_creds.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
class KaggleCredentials:
DEFAULT_CREDENTIALS_FILE = "~/.kaggle/credentials.json"
DEFAULT_ACCESS_TOKEN_EXPIRATION = timedelta(hours=12)
ACCESS_TOKEN_REFRESH_MARGIN = timedelta(minutes=30)

def __init__(
self,
Expand Down Expand Up @@ -115,9 +116,10 @@ def refresh_access_token(self) -> None:
self.save()

def access_token_has_expired(self) -> bool:
return not self._access_token_expiration or self._access_token_expiration < datetime.now(
timezone.utc
) - timedelta(minutes=30)
return (
not self._access_token_expiration
or self._access_token_expiration - KaggleCredentials.ACCESS_TOKEN_REFRESH_MARGIN < datetime.now(timezone.utc)
)

def get_access_token(self) -> str:
if not self._access_token or self.access_token_has_expired():
Expand Down
Loading