Skip to content
This repository was archived by the owner on Nov 24, 2022. It is now read-only.

Conversation

@rflechtner
Copy link
Contributor

@rflechtner rflechtner commented Jun 11, 2020

part of KILTProtocol/ticket#530

This pushes dev images of the demo client to dockerhub with a dedicated tag (develop). These images are not super useful for local testing though; they are set up to connect to a kilt full node.

Outstanding issue(s):

  • Images do not connect because connection config is wrong

How to test:

A successful test run has been triggered by 89307a1 (see here). You can also pull the image from dockerhub (kiltprotocol/demo-client) and run it

Checklist:

  • I have verified that the code works
  • I have verified that the code is easy to understand
    • If not, I have left a well-balanced amount of inline comments
  • I have left the code in a better state
  • I have documented the changes (where applicable)

@wischli wischli self-requested a review June 11, 2020 09:37
did not work when running demo client images locally
This reverts commit 89307a1.
@rflechtner
Copy link
Contributor Author

I'm having issues if I build the dockerfile locally - when I run it and try to access it on the port I mapped, I get an empty page and an error in the console:

[Error] SyntaxError: Unexpected token '<'
	(anonymous function) (main.bb389772.js:1)

@rflechtner
Copy link
Contributor Author

this is on hold bc we realised these docker images are not really useful; may remove the demo-client from dockerhub

@rflechtner rflechtner added the ✋on hold status: on hold label Jun 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

✋on hold status: on hold

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants