Skip to content
This repository was archived by the owner on Nov 24, 2022. It is now read-only.

Conversation

@aenyway
Copy link
Contributor

@aenyway aenyway commented May 15, 2019

start of implementation

  • i intended to get rid of the <CTypeEditor /> component completely, since it just is a obsolete wrapper
  • instead i planned to move all the logic to <CTypeCreate />
  • both <SchemaEditor /> & <PlainSchemaEditor /> only collect the user input and pass it to <CTypeCreate />
  • even the error handling should be done there, so we have consistent error handling
  • for this we should disable the error handling of the <SchemaEditor /> (maybe configurable, otherwise just hide it via css)
  • the only error handing we might not handle in <CTypeCreate /> is the 'Invalid JSON' error of the <PlainSchemaEditor />, this one can only appear there and could be handled there

start of implementation
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants