feat(runtime): always expose caCertificate and disableTlsVerification…#1203
Open
gastonyelmini wants to merge 1 commit into
Open
feat(runtime): always expose caCertificate and disableTlsVerification…#1203gastonyelmini wants to merge 1 commit into
gastonyelmini wants to merge 1 commit into
Conversation
… from env These two fields back the platform-wide "agent configurations" feature (IntegrationPlatformFeatures.supportsAgentConfigurations) and are set by the customer through the global UI form, not declared per-integration. loadConfigFromEnvironmentVariables previously only iterated entries in the integration's instanceConfigFields, so any integration that did not re-declare these fields received undefined for both at runtime — even though the platform had written CA_CERTIFICATE / DISABLE_TLS_VERIFICATION into the environment. Merge them in as implicit optional fields. Integration-declared entries for the same keys still win, and createIntegrationInstanceForLocalExecution now always runs the loader (with an empty map if no instanceConfigFields were supplied) so the implicit fields surface even for integrations that do not declare a config schema of their own.
VDubber
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… from env
These two fields back the platform-wide "agent configurations" feature (IntegrationPlatformFeatures.supportsAgentConfigurations) and are set by the customer through the global UI form, not declared per-integration. loadConfigFromEnvironmentVariables previously only iterated entries in the integration's instanceConfigFields, so any integration that did not re-declare these fields received undefined for both at runtime — even though the platform had written CA_CERTIFICATE / DISABLE_TLS_VERIFICATION into the environment.
Merge them in as implicit optional fields. Integration-declared entries for the same keys still win, and createIntegrationInstanceForLocalExecution now always runs the loader (with an empty map if no instanceConfigFields were supplied) so the implicit fields surface even for integrations that do not declare a config schema of their own.