chore(chromatic): neuter Chromatic steps in shared frontend templates#174
Closed
karsonkalt wants to merge 1 commit into
Closed
chore(chromatic): neuter Chromatic steps in shared frontend templates#174karsonkalt wants to merge 1 commit into
karsonkalt wants to merge 1 commit into
Conversation
The JupiterOne Chromatic account is being decommissioned. Four shared
frontend templates currently invoke `actions/frontend/chromatic@v3.0.53`
to upload to Chromatic. Strip the upload step from each template,
keeping:
- The `chromatic_upload` / `chromatic_publish` job (preserves the
"Visual Regression" job name that branch protections rely on)
- The `if: ${{ inputs.use_chromatic }}` gate (most callers pass false
already, only web-juno opts in)
- An echo step so the job reports success without making any
Chromatic API call
Templates touched:
- frontend_npm_pr.yml
- frontend_npm_release.yml
- frontend_runtime_application_pr.yml
- frontend_runtime_utility_pr.yml
The composite action at `.github/actions/frontend/chromatic` is now
orphaned; deletion is tracked as follow-up cleanup.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
ryanmcafee
approved these changes
May 26, 2026
Contributor
Author
|
Closing and removing the consumer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In This PR
Four reusable templates currently invoke
jupiterone/.github/.github/actions/frontend/chromatic@v3.0.53. Each one's chromatic step is replaced with anechono-op; everything else (job name, runner,if: ${{ inputs.use_chromatic }}gate, surrounding workflow structure) stays exactly the same.frontend_npm_pr.ymlchromatic_upload(namedVisual Regression)chromatic_uploadfrontend_npm_release.ymlchromatic_publishchromatic_publishfrontend_runtime_application_pr.ymlchromatic_upload(namedVisual Regression)chromatic_uploadfrontend_runtime_utility_pr.ymlchromatic_upload(namedVisual Regression)chromatic_uploadNotes
The JupiterOne Chromatic account is being decommissioned. Three
Visual Regression-named jobs are referenced by branch protection rules ("Name targeted by branch protections, do not change" — see existing comments in the templates), so the job structure and name must stay. After this PR, those jobs run a singleechostep and post success — branch protection happy, no Chromatic API call.Callers actually opting in (
use_chromatic: true): onlyJupiterOne/web-juno. The other ~13 referencing repos passuse_chromatic: false, so the gated job didn't run for them anyway — this change has zero behavioral effect on them today, but it future-proofs against anyone flipping the knob later.Composite action orphaned.
.github/actions/frontend/chromatic/action.ymlno longer has any caller after this lands. Deletion is tracked as follow-up cleanup, not blocking.[*] Authored by Claude Code.