Skip to content

Give UnivariateKDE distribution-like overloads#91

Open
ChrisRackauckas wants to merge 1 commit intoJuliaStats:masterfrom
ChrisRackauckas:patch-1
Open

Give UnivariateKDE distribution-like overloads#91
ChrisRackauckas wants to merge 1 commit intoJuliaStats:masterfrom
ChrisRackauckas:patch-1

Conversation

@ChrisRackauckas
Copy link

Upstreams SciML/SciMLExpectations.jl#41 . Allows for it to be "distribution-like". Still missing the random sampling.

Upstreams SciML/SciMLExpectations.jl#41 . Allows for it to be "distribution-like". Still missing the random sampling.
Base.eltype(K::UnivariateKDE) = eltype(K.density)
Base.minimum(K::UnivariateKDE) = minimum(K.x)
Base.maximum(K::UnivariateKDE) = maximum(K.x)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about Base.extrema?

@agerlach
Copy link

agerlach commented May 4, 2021

Any status update on getting this PR merged?

@tpapp
Copy link
Collaborator

tpapp commented May 5, 2021

Is it actually guaranteed that the the support is zero outside the extrema of x? I would have to look at the code, but I don't think it holds in general. Eg for a Normal kernel (which is the default), the support is the real line. x are just the points where it is precalculated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments