Skip to content

Rename generic_mat***mul! to mul! - #746

Open
dkarrasch wants to merge 3 commits into
mainfrom
dk/generic-matmatmul!
Open

Rename generic_mat***mul! to mul!#746
dkarrasch wants to merge 3 commits into
mainfrom
dk/generic-matmatmul!

Conversation

@dkarrasch

@dkarrasch dkarrasch commented Aug 16, 2026

Copy link
Copy Markdown
Member

Follow-up to JuliaLang/LinearAlgebra.jl#1671.

This will work only after JuliaLang/LinearAlgebra.jl#1676 is merged and LinearAlgebra.jl is bumped.

@codecov

codecov Bot commented Aug 16, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.71%. Comparing base (2f05a07) to head (75cdfa2).

Files with missing lines Patch % Lines
src/linalg.jl 66.66% 1 Missing ⚠️
src/sparsevector.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #746      +/-   ##
==========================================
- Coverage   84.40%   83.71%   -0.70%     
==========================================
  Files          13       13              
  Lines        9381     9380       -1     
==========================================
- Hits         7918     7852      -66     
- Misses       1463     1528      +65     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dkarrasch dkarrasch closed this Aug 17, 2026
@dkarrasch dkarrasch reopened this Aug 17, 2026
@dkarrasch dkarrasch closed this Aug 18, 2026
@dkarrasch dkarrasch reopened this Aug 18, 2026
@dkarrasch dkarrasch closed this Aug 21, 2026
@dkarrasch dkarrasch reopened this Aug 21, 2026
@araujoms araujoms closed this Aug 25, 2026
@araujoms araujoms reopened this Aug 25, 2026
araujoms
araujoms previously approved these changes Aug 25, 2026
@dkarrasch dkarrasch added the backport 1.13 Change should be backported to release-1.13 label Aug 26, 2026
@dkarrasch

Copy link
Copy Markdown
Member Author

I can't get julia nightly to run on my machine. @araujoms Would you be able to check the call paths for the two methods that are seemingly uncovered?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 1.13 Change should be backported to release-1.13

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants