Skip to content

Conversation

@MaxenceGollier
Copy link
Collaborator

@MaxenceGollier MaxenceGollier mentioned this pull request Jan 5, 2026
6 tasks
shifted(reg_nlp.h, xk)

Bk = hess_op(reg_nlp.model, x0)
Bk = hess_op(reg_nlp.model, xk)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dpo, in TR and TRDH, we do it like this:

Bk =
    isa(reg_nlp.model, QuasiNewtonModel) ? hess_op(reg_nlp.model, xk) :
    hess_op!(reg_nlp.model, xk, similar(xk))

but I am not sure to understand why.

@codecov
Copy link

codecov bot commented Jan 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.66%. Comparing base (e0f214d) to head (3cbcf51).
⚠️ Report is 259 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #274       +/-   ##
===========================================
+ Coverage   61.53%   84.66%   +23.13%     
===========================================
  Files          11       13        +2     
  Lines        1292     1624      +332     
===========================================
+ Hits          795     1375      +580     
+ Misses        497      249      -248     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant