[backport] Add availability flags in NLPModelMeta and NLSMeta #525
+140
−71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This was referenced Dec 2, 2025
tmigot
requested changes
Dec 3, 2025
Member
tmigot
left a comment
tmigot
left a comment
There was a problem hiding this comment.
So, the implementation of NLPModels should set one of this flag to false is something is not implemented. We should also document it somewhere, if no obvious place in the NLPModels doc maybe the docstrings of the function to implement.
What is the motivation for this? Is that automatic solver selection ?
In ADNLPModels, it can even be automatic by checking whether EmptyADBackend is mentioned.
Comment on lines
+297
to
+302
| gradient_available = gradient_available, | ||
| jacobian_available = jacobian_available, | ||
| hessian_available = hessian_available, | ||
| Jv_available = Jv_available, | ||
| Jtv_available = Jtv_available, | ||
| Hv_available = Hv_available, |
Member
There was a problem hiding this comment.
What about names that are closer to the implemented functions?
grad (or grad!), jac, hess, hprod, jprod, jtprod
Member
Author
|
@tmigot The motivation is here: #524 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #524 but for the branch
0.21.xwhich allows backporting some commits.We can also check that we don't break anything, the breakage workflow should work here.