Cleanup, fixes and better listNeighborhood#1206
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR focuses on cleaning up and improving graph neighborhood/listing utilities and related APIs (filters, deprecations), along with some consistency fixes across GraphsDFG storage fields, timestamp utilities, and exported/public surface area.
Changes:
- Refactors
listNeighborhood/neighbor utilities to support filters and to return variables/factors separately; updates subgraph building and tests accordingly. - Updates GraphsDFG merge behavior (more specific error type) and standardizes
blobStores→blobstoresacross in-memory and file save/load paths. - Improves timestamp delta computation performance and refreshes various exports/public APIs and printing labels.
Reviewed changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| test/testBlocks.jl | Updates tests for new error types and neighborhood/subgraph behavior. |
| src/services/list.jl | Introduces listNeighborsSecondary and keeps ls2 as a compatibility alias. |
| src/services/find.jl | Refactors closest-timestamp computation and renames parameters for clarity. |
| src/services/Tags.jl | Minor cleanup and TODO note for tag-merge return semantics. |
| src/services/DFGVariable.jl | Adds deprecation warning for manifold conversion; adds hasState convenience overload. |
| src/services/DFGFactor.jl | Generalizes getVariableOrder to AbstractGraphFactor. |
| src/services/CustomPrinting.jl | Tweaks show output labels and formatting. |
| src/services/Bloblet.jl | Adds TODO note (no functional change). |
| src/services/AbstractDFG.jl | Core API updates: neighborhood return type/filters; adds node-based listNeighbors forwarder; updates subgraph/mergeGraph plumbing. |
| src/GraphsDFG/services/GraphsDFG.jl | Aligns mergeFactor error semantics; updates neighborhood filtering and return type. |
| src/GraphsDFG/entities/GraphsDFG.jl | Renames blobstore field; adds a copy-style constructor. |
| src/GraphsDFG/GraphsDFG.jl | Adds rebuildFactorCache! warning fallback for NoSolverParams. |
| src/FileDFG/services/FileDFG.jl | Updates save/load paths to use renamed blobstores field. |
| src/DistributedFactorGraphs.jl | Reorganizes exports/public API and unstable function listing. |
| src/Deprecated.jl | Adds deprecated getVariable(dfg, label, stateLabel) shim. |
| src/DataBlobs/services/BlobStores.jl | Expands ~ in FolderStore paths; adds serialization metadata to LinkStore cache. |
| src/DataBlobs/entities/BlobEntry.jl | Aligns constructor keyword argument types with entity fields. |
| src/Common.jl | Adds faster calcDeltatime_ns and a Timestamp(::Microsecond) constructor. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #1206 +/- ##
===========================================
- Coverage 72.66% 72.05% -0.62%
===========================================
Files 36 37 +1
Lines 2294 2315 +21
===========================================
+ Hits 1667 1668 +1
- Misses 627 647 +20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.