Pin action and Docker image refs to SHAs; add GPG commit signing#527
Merged
IanButterworth merged 3 commits intomasterfrom Mar 24, 2026
Merged
Pin action and Docker image refs to SHAs; add GPG commit signing#527IanButterworth merged 3 commits intomasterfrom
IanButterworth merged 3 commits intomasterfrom
Conversation
01aed51 to
8416ae6
Compare
- action.yml: use Docker image SHA digest instead of version tag - example.yml, README.md, IMPROVEMENTS.md, .github/workflows/tagbot.yml: pin JuliaRegistries/TagBot refs to commit SHA with version comment - bin/publish.py: build and push versioned Docker image during workflow_dispatch (before PR), extract digest for action.yml pin; on PR merge, checkout master, update all action ref pins and push, then tag and create release always targeting the merge commit SHA, then push floating Docker tags - .github/workflows/publish.yml: import GPG key via crazy-max/ghaction-import-gpg, set git identity from key UID, enable signed commits for all subsequent steps Co-authored-by: Claude <claude@anthropic.com>
- environment: production gates the job on required reviewers, protecting all secrets from exfiltration via a compromised write-access token - GPG key import and git signing config inlined as bash (replaces crazy-max/ghaction-import-gpg) for full auditability; key is deleted from the keyring in a cleanup step with if: always() Requires creating a 'production' environment in Settings → Environments with required reviewers. Secrets should be moved into the environment secret store so they are only accessible to approved runs.
DilumAluthge
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JuliaRegistries/TagBotaction refs to commit SHA with# v{version}commentworkflow_dispatch(before PR is opened), extract SHA digest foraction.ymlpin; on PR merge, checkout master, update all action ref pins and push, then tag and create release always targeting the merge commit SHA, then push floating Docker tagsproductionenvironment so secrets require human approval to access (requires creating the environment in Settings → Environments with required reviewers, and moving secrets into the environment secret store)