Giant refactor to move all global state into a ClusterContext#61
Open
JamesWrigley wants to merge 2 commits intomasterfrom
Open
Giant refactor to move all global state into a ClusterContext#61JamesWrigley wants to merge 2 commits intomasterfrom
ClusterContext#61JamesWrigley wants to merge 2 commits intomasterfrom
Conversation
The main reason is to make it easier to execute a precompilation workload. Other possible future uses are simplifying the tests by reinitializing the context in each testset so that there's guaranteed to not be any old state from previous tests, and multi-cluster support.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #61 +/- ##
==========================================
- Coverage 88.54% 88.21% -0.33%
==========================================
Files 12 12
Lines 2235 2232 -3
==========================================
- Hits 1979 1969 -10
- Misses 256 263 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
If there's no objections I'll merge this at the end of the week. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main reason is to make it easier to execute a precompilation workload. Other possible future uses are simplifying the tests by reinitializing the context in each testset so that there's guaranteed to not be any old state from previous tests, and multi-cluster support.
Written with help from Claude 🤖