Require TriangularSolve 0.2.2 for the native upper-triangular ldiv! - #112
Merged
ChrisRackauckas merged 1 commit intoAug 8, 2026
Conversation
TriangularSolve 0.2.2 adds ldiv!(::UpperTriangular, ::AbstractMatrix), so the U leg of the pivotless LU ldiv! in src/lu.jl now hits a native SIMD kernel instead of silently falling through TriangularSolve's catch-all to BLAS trsm. No code change needed here; the call site already routes both legs through TriangularSolve.ldiv!. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
ChrisRackauckas
marked this pull request as ready for review
August 8, 2026 07:59
ChrisRackauckas
merged commit Aug 8, 2026
366295b
into
JuliaLinearAlgebra:master
0 of 19 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚧 Blocked on TriangularSolve 0.2.2 being merged and registered (native upper-triangular
ldiv!, prepared at ChrisRackauckas-Claude/TriangularSolve.jlupper-ldiv; spec in SciML/LinearSolve.jl#1146). Until it is registered, CI here fails atPkgresolution because the0.2.2lower bound does not exist yet.What changed and why
Compat-only: require
TriangularSolve = "0.2.2"and bump this package to 0.2.27. TriangularSolve 0.2.2 addsldiv!(::UpperTriangular, ::AbstractMatrix), so the U leg of the pivotless (NotIPIV) LUldiv!insrc/lu.jl— which already callsTriangularSolve.ldiv!on both legs — now dispatches to a native SIMD kernel instead of silently falling through TriangularSolve's catch-all to BLAStrsm. No code change is needed here.Verification
Full test suite run locally (Julia 1.12.4, AMD EPYC 7502) with the TriangularSolve
upper-ldivbranchPkg.developed:The
🦋testset errors on this branch and on unmodified master withUndefVarError: mul! not defined in RecursiveFactorization— a pre-existing master breakage introduced by 0e635a2 (see the bisect + one-line fix in #111, which this PR depends on for green CI). It is unrelated to this compat change.Solve-only kernel benchmark backing the change (Float64, nrhs=8, 1 BLAS thread, EPYC 7502/AVX2;
U-leg comparison ofLinearAlgebra.ldiv!(BLAS trsm, the old fallback) vsTriangularSolve.ldiv!0.2.2 native):What was not verified
🤖 Generated with Claude Code