Skip to content

Conversation

@LilithHafner
Copy link
Member

WIP c.f. JuliaLang/julia#52784

There will also need to be changes to eval, though I think lowering already supports this.

@codecov
Copy link

codecov bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a6f2d15) 94.61% compared to head (229a4e2) 96.54%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #406      +/-   ##
==========================================
+ Coverage   94.61%   96.54%   +1.92%     
==========================================
  Files          14       14              
  Lines        4178     4195      +17     
==========================================
+ Hits         3953     4050      +97     
+ Misses        225      145      -80     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LilithHafner LilithHafner changed the title Allow using Mod as NewName in v1.11+ Allow using Mod as NewName in v1.13+ Apr 11, 2025
@c42f
Copy link
Member

c42f commented Nov 20, 2025

Heya, we just moved JuliaSyntax into Base in JuliaLang/julia#59870 - if you want to re-propose this PR over there, I've created a branch https://github.com/JuliaLang/JuliaSyntax.jl/tree/pr-for-Base/406 to make this easier.

To make use of the branch, you can use the following steps:

  • Clone JuliaLang/julia
  • Add JuliaSyntax as a git remote
  • Check out pr-for-Base/406
  • Rebase on top of master

For example:

# git clone git@github.com:JuliaLang/julia julia_dir
# cd julia_dir

git remote add JuliaSyntax git@github.com:JuliaLang/JuliaSyntax.jl
git fetch JuliaSyntax
git checkout pr-for-Base/406
git rebase origin/master

Sorry this wasn't dealt with prior to the big move!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants