Complete tests#243
Conversation
Benchmark Results
Benchmark PlotsA plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR. |
|
2 cents thought on the intempestive The The main concern (or worry, so to speak) is that decorations always feel inherently problem-dependent to me. What counts as a 'safe' decoration really depends on the user's context, doesn't it? (in particular, this is why all set operations result in the If so, following that logic, users should perhaps upgrade the decoration to EDIT: Or there could be a special keyword |
|
After sleeping on it, I think that I agree, we should just keep the decoration while bisecting, because the interval may come from a previous computation, that got the I'm considering hiding the decoration while displaying the root however, but that should be done in a different PR. Also, I will open a PR in IA.jl to have |
Fix #115
Also suppresses warning from tests that printed them.
This is not finished yet, I open it however to allow discussion on one weird behavior that I would while completing the tests:
bisectuse the decoration of the parent interval. This is very reasonnable in general, however it also means that interval bisected frominterval(-Inf, Inf)will all have the decroationdac. I belive that this is not what we want here, so I changed it.Reporting the list from #115
Out of domainsuite.Infinite domainsuite.NaN return valuesuite.test/bisection.jl.test/findroots.jlto therootssuite.test/newton1d.jlto the tests for the 1Drootssuite.examplefolder run without error.docs/test_suites.md.