Matmul: Switch to trailing batch dims and allow mat-vec, vec-mat#132
Merged
maleadt merged 3 commits intoJuliaGPU:mainfrom Mar 25, 2026
Merged
Matmul: Switch to trailing batch dims and allow mat-vec, vec-mat#132maleadt merged 3 commits intoJuliaGPU:mainfrom
maleadt merged 3 commits intoJuliaGPU:mainfrom
Conversation
When operands have different numbers of batch dimensions (e.g. (M, K, 4) * (K, N, 2, 4)), _matmul pads the shorter batch tuple with ones to align them before computing the output shape and creating the zero accumulator. _muladd does the same padding to reshape operands before broadcasting. These two functions disagreed on *where* to pad: _matmul inserted leading ones ((1, 4) for a 1-batch operand against a 2-batch one) while _muladd appended trailing ones ((4, 1)). This meant the acc shape from _matmul wouldn't match what _muladd expected, causing a reshape element-count mismatch at the Tile IR level. Fix _matmul to use trailing ones, consistent with _muladd. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
maleadt
approved these changes
Mar 25, 2026
Member
maleadt
left a comment
maleadt
left a comment
There was a problem hiding this comment.
Let's hope the additional permutes here are free?
Contributor
Author
|
Hopefully🤞 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #115