Move traits to ProximalCore.jl & implement is_locally_smooth where suitable #152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…itable
Besides removing traits.jl that contained the functions moved to ProximalCore.jl
and applying renaming that occured in ProximalCore.jl v0.2.0, the commit contains
the following changes:
Added traits:
- `is_proximable = true` added to `SqrNormL2`
- `is_positively_homogeneous = true` added to `SumPositive`
- `is_locally_smooth = true` added to `LogBarrier`
- `is_locally_smooth = true` added to `NormL2`
`is_locally_smooth(T{W}) = is_locally_smooth(W)` added where W is the wrapped function:
- `Postcompose`
- `Precompose`
- `PrecomposeDiagonal`
- `Regularized`
- `SeparableSum`
- `SlicedSeparableSum`
- `Sum`
- `Tilt`
- `Translate`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Besides removing traits.jl that contained the functions moved to ProximalCore.jl and applying renaming that occurred in ProximalCore.jl v0.2.0, the commit contains the following changes:
Added
[workspace]entry to Project.toml. It's a Julia v1.12 feature, ignored by previous versions, that synchronizes versions between subprojectstest,docs, andbenchmark.Added traits:
is_proximable = trueadded toSqrNormL2is_positively_homogeneous = trueadded toSumPositiveis_locally_smooth = trueadded toLogBarrieris_locally_smooth = trueadded toNormL2is_locally_smooth(T{W}) = is_locally_smooth(W)added where W is the wrapped function:PostcomposePrecomposePrecomposeDiagonalRegularizedSeparableSumSlicedSeparableSumSumTiltTranslateImplements part of #151