Repository navigation
Shift test arguments of logitexp and logit1mexp to their domain - #333
Merged
Merged
Conversation
`LogExpFunctions.logitexp` and `logit1mexp` are only defined for `x < 0`. JuliaDiff/DiffRules.jl#121 adds rules for them, so the tests that loop over all DiffRules rules evaluate them at `rand()` and throw a `DomainError`. Treat them like `log1mexp` and `log2mexp`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #333 +/- ##
=======================================
Coverage 94.77% 94.77%
=======================================
Files 19 19
Lines 1703 1703
=======================================
Hits 1614 1614
Misses 89 89 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LogExpFunctions.logitexpandlogit1mexpare only defined forx < 0. JuliaDiff/DiffRules.jl#121 adds DiffRules rules for them. The tests that loop over all rules inDiffRules.diffrules()evaluate them atrand()in (0, 1), and the primal call throws aDomainError(logexpm1→logof a negative number). This PR shifts their arguments by-1, as forlog1mexpandlog2mexp.With DiffRules' current release these functions have no rules, so the change has no effect there. It only matters once DiffRules#121 is released.
I checked the change locally against the DiffRules#121 branch: ForwardDiff's
DualTest.jland ReverseDiff'sderivatives/ScalarTests.jlandderivatives/ElementwiseTests.jlall pass.🤖 Generated with Claude Code