Repository navigation
Port JSONTables to JSON.jl 1.x - #29
Merged
Merged
Conversation
Read with JSON.parse and write with JSON.json; drop the JSON3 and
StructTypes dependencies. jsontable now accepts any AbstractDict of
column vectors or AbstractVector of AbstractDict rows, keyed by String
or Symbol, so already-parsed JSON3 objects keep working. Column types
are computed from the values, since JSON.parse returns Vector{Any}.
JSON.jl 1.x requires Julia 1.10, so the Julia floor and the CI minimum
move to 1.10 (lts).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #29 +/- ##
==========================================
+ Coverage 93.81% 96.93% +3.12%
==========================================
Files 1 1
Lines 97 98 +1
==========================================
+ Hits 91 95 +4
+ Misses 6 3 -3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces JSON3 + StructTypes with JSON.jl 1.x.
jsontable(source)reads withJSON.parse;objecttable/arraytablewrite withJSON.json.jsontableaccepts anyAbstractDictof column vectors orAbstractVectorofAbstractDictrows, keyed byStringorSymbol, so parsed JSON3 objects still work.JSON.parsereturnsVector{Any}), so schemas stay concrete, e.g.Int64orUnion{Missing, Float64}.jsontable(source; kw...)now go toJSON.parseinstead ofJSON3.read.Tested locally: 58/58 on Julia 1.12 with JSON 1.10.0 and with JSON 1.0.0 (compat floor), and on Julia 1.10. Also checked JSON3 inputs, DataFrames round-trips, column order on write, and a 300-column write.
🤖 Generated with Claude Code