Repository navigation
Conversation
A calculated, signed and witnessed run refused on answer and table-time tampering; a failed calculation kept signed and witnessed with a malformed receipt pin refused; a live key replacement refused against Desk's public-key list; Desk's audit checkpoint --since hand-over across changing chain snapshots verified against independently retained checkpoints. Tests only. Drafted with an OpenAI model (Codex CLI); checked and committed by the coordinator. Signed-off-by: kikashy <35789537+kikashy@users.noreply.github.com> Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #56 (finding 5, MEDIUM, of the cross-vendor audit of the chain of runs, #57). Tests only: no file under
internal/other than_test.gofiles changes.What changes
Four integration tests in
internal/runnerhold the combinations the audit found tested only apart:TestACalculatedSignedAndWitnessedRunRefusesAnswerAndTableTimeTampering: a run with calculated exports, required signing and held checkpoints; the answer tampered and the table time tampered are each refused with their exact findings. Disabling the retained-disposition binding in a scratch copy makes it fail.TestAFailedCalculationIsSignedAndWitnessedAndAMalformedReceiptPinIsRefused: a failed calculation (cannot-compute) is kept inside a signed and witnessed run; an identity-point receipt pin is refused. Replacing the curve validation with hex decoding makes it fail.TestALiveKeyReplacementCannotPassDesksPublicKeyList: the listed key's run is accepted; the replacement key's run reportssignature-invalid. Forcing signature verification to true makes it fail.TestDeskCheckpointSinceHandsOverChangingChainSnapshotsExactly: bothaudit checkpoint --sincebatches are compared byte for byte against the published runtime, and the later snapshot is verified against both independently retained checkpoint files. Replacing the previous links with the empty digest makes the runtime refuse the snapshot and the test fail.Checks
Drafted with an OpenAI model (Codex CLI) in a scratch clone (
gofmt -l,go vet ./..., the four tests with the published runtime; two existing runtime-signed tests could not run there because its sandbox owns/as an unprivileged user, which the runtime refuses). Committed by the coordinator aftergofmt -l,go vet ./...andgo test ./...with the published runtime under the machine's memory cap. CI runs the suites.Review
Tests only; no review round, by the rule for tests.
Closes #56
🤖 Generated with Claude Code