Maintain digital volume balances also when on_underflow was used#103
Merged
michaelosthege merged 3 commits intomasterfrom Jul 18, 2025
Merged
Maintain digital volume balances also when on_underflow was used#103michaelosthege merged 3 commits intomasterfrom
on_underflow was used#103michaelosthege merged 3 commits intomasterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #103 +/- ##
==========================================
+ Coverage 95.75% 95.78% +0.02%
==========================================
Files 19 19
Lines 1202 1209 +7
==========================================
+ Hits 1151 1158 +7
Misses 51 51 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
Self-reviewed this. Noticed that aspirating from throughs with The implementation will not warn about all wells at the same time, but only start warning once the iterator reaches wells for which the remaining volume in the trough is insufficient. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#102 describes a bug that was overlooked in #101 and lead to violating mass balances in the volume tracking.
This PR fixes the transfer-related worklist operations by
Labware.remove,BaseWorklist.aspirate,EvoWorklist.evo_aspiratemethodsEvoWorklist.transferandFluentWorklist.transferto pass aspiratable volumes toLabware.dispenseas an override such that generated commands still dispensevolume, but digital liquid volume tracking is only updated with the same volume that was digitally aspirated from the source.