Run dos2unix on *.py and tidyup some files.#20
Open
tomgreen66 wants to merge 1 commit intoJonJala:masterfrom
Open
Run dos2unix on *.py and tidyup some files.#20tomgreen66 wants to merge 1 commit intoJonJala:masterfrom
tomgreen66 wants to merge 1 commit intoJonJala:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Been helping a user run this code on our systems at Cardiff University and hit a few issues:
^Mnewline characters causing problems if you run./mtag.pyrather thanpython ./mtag.py. Runningdos2unixacross all.pyfiles fixed a couple of files. This could be fixed using git configuration options to convert newline characters on clone depending on system but opinion online seemed to be divided whether that is a bit cumbersome..pycis not required and added a.gitignorefile to stop similar files being added.Hopefully others will find this useful.